css Flex, css Grid

Community feedback

• 

  Lucas 👾•104,340

  @correlucasPosted about 2 years ago

  👾Hello NikitaBenzin, Congratulations on completing this challenge!

  Amazing solution! I’ve just opened the solution’s live site and I liked the job you’ve done a lot. I’ve some suggestions for you:

  1.To save your time you can code you whole page using px and then in the end use a VsCode plugin called px to rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

  2.The box-shadow is a bit too strong, this is due the opacity and blur. The secret to create a perfect and smooth shadow is to have low values for opacity and increase blur try this value instead: box-shadow: 12px 7px 20px 6px rgb(57 75 84 / 8%);

  If you’re not familiar to box-shadow you can use this site to create the shadow design and then just drop the code into the CSS: https://html-css-js.com/css/generator/box-shadow/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  1
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Nikita, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • You can add the effect :hover creating a div that appears on hover. I used tailwind but you can still see and understand which css properties you can use to do the same. Look here -> my solution
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of texts
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

  Hope this help! Happy coding 😉

  Marked as helpful

  1
• 

  Hyron•5,870

  @hyrongennikePosted about 2 years ago

  Hi @NikitaBenzin,

  I see the card is slightly off center even though you're using place-items: center that's because there's another div under the card div so grid takes that into count creating 2 row. You can either remove the div or use flexbox as below.

  body { margin: 0; font-family: 'Outfit', sans-serif; font-size: 18px; background-color: var(--blue-500); display: flex; justify-content: center; align-items: center; min-height: 100vh; }

  just something to keep in mind for your next challenge, also check the issues in the report above I think it's because you didn't use a main tag.

  Hope this helpful.

  Marked as helpful

  1