Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

CSS Flex

James 340

@jacram

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

romila 3,570

@romila2003

Posted

Hi James,

Congratulations 🎉 on completing this challenge, it was a great attempt but there are some minor problems I want to address:

  1. It is best practice to wrap your code in the main tag as this is semantically correct e.g. <main class="container"></main>
  2. It is best practice to wrap your footer within the footer tag as this is semantically correct e.g. <footer class="attribute"></footer>
  3. Regarding your background, it would have been more ideal to have given the body tag, a background-color as it will cover the whole body. In your code, the background only covers the container therefore the bottom (footer) is not affected.
  4. There is a lot of white space within the card which should be reduced to look more similar to the design.

Overall, great attempt and keep coding 👍.

0

James 340

@jacram

Posted

@romila2003 Thanks Mark for the great feedback I'll definitely be working on those things in the future

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord