romila• 3,570
@romila2003
Posted
Hi James,
Congratulations 🎉 on completing this challenge, it was a great attempt but there are some minor problems I want to address:
- It is best practice to wrap your code in the
main
tag as this is semantically correct e.g.<main class="container"></main>
- It is best practice to wrap your footer within the
footer
tag as this is semantically correct e.g.<footer class="attribute"></footer>
- Regarding your background, it would have been more ideal to have given the
body
tag, abackground-color
as it will cover the whole body. In your code, the background only covers the container therefore the bottom (footer) is not affected. - There is a lot of white space within the card which should be reduced to look more similar to the design.
Overall, great attempt and keep coding 👍.
0
James• 340
@jacram
Posted
@romila2003 Thanks Mark for the great feedback I'll definitely be working on those things in the future
1