CSS flex and media query ( 390px )

Community feedback

• 

  Ricky•460

  @rickyxyzPosted 12 months ago

  Fellow beginner here, so take this with a grain of salt 🧂.

  I think this could be helpful for you BEM naming convention, since CSS names can get confusing quickly.

  Cheers 🍻

  Marked as helpful

  2

  ---

  

  Cyril Salamite•70

  @CyrilangePosted 12 months ago

  @rickyxyz

  Thank you very much , this advise is a great help for me and for people looking at the project

  cheers

  0
• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 12 months ago

  Hello there 👋. Good job on completing the challenge !

  I have other suggestions about your code that might interest you.

  • Avoid using the <div> tag just for text. <div> is a generic container used for grouping content and applying styles, but it doesn't convey any semantic meaning. Similarly, avoid using <span> for entire blocks of text, <span> is an inline HTML element used to apply styles to specific parts of text without changing the structure or meaning, but this tag doesn't provide the same semantic value as other tags like paragraphs.

  • You should use aria-hidden="true" and focusable="false" in an SVG to improve accessibility. These attributes are essential to provide a better experience for users with disabilities, as they indicate that the SVG is decorative or non-interactive.

  I hope you find it useful! 😄

  Happy coding!

  Marked as helpful

  1

  ---

  

  Cyril Salamite•70

  @CyrilangePosted 12 months ago

  @MelvinAguilar

  Thank you , yes every comments is useful

  0
• 

  Renukta-21•130

  @Renukta-21Posted 12 months ago

  Saw your code, and I think you could simplify much more your styles, also you can check the repeated styles that are in the same file, noticed you have tha same media-query distributed all along your file for different elements, I'm a beginner to btw, congrats!

  Marked as helpful

  1

  ---

  

  Cyril Salamite•70

  @CyrilangePosted 12 months ago

  @Renukta-21

  Thank you , I could have used mixing and variables indeed

  1