css flex and direction

Community feedback

• 

  Daniel 🛸•44,250

  @danielmrz-devPosted 5 months ago

  Hello there!

  Congrats on completing the challenge! ✅

  Your project looks great!

  I have a suggestion about your code that might interest you:

  📌 You can use the <picture> tag when you have different versions of the same image.

  Using the <picture> tag will help load the correct image to the user's device, saving bandwidth and improving performance.

  Example:

  <picture>
      <source media="(min-width: 768px)" srcset="{desktop image path here}">
      <img src="{mobile image path here}" alt="{alternative text here}">
  </picture>
  

  I hope this helps!

  Other than that, excellent work!

  0
• 

  Shoaib Shuja•560

  @ShoaibShujaPosted 5 months ago

  Amazing job my friend and here are some suggestions for you to make your code better:

  • First of all wrap all your code in a section or div element especially if the design is basically covered in a box.

  • Also don't use section element unless you are covering a bunch of elements which depends on each other or are related

  • Also, in this particular challenge it would have been better to use a img element inside your div instead of putting it as the background

  • Another thing if you want to perfectly center a box inside the body element use these lines of code:

  body {
      width: 100%;
      min-height: 100vh;
      display: flex;
      justify-content: center;
      align-items: center;
  }
  

  • If you want to use media queries for smaller devices use @media screen and (max-width: 650px) and not min-width. min-width applies the media query to devices which have a width more than the one you set the property equal to.

  You code was overall good and simple. So keep learning and I wish you best of lucks.

  0