
Design comparison
Solution retrospective
This is my first work about this. I did it, that make me so happy.
What challenges did you encounter, and how did you overcome them?The layout. There are too many layout roles, such as flex, grid. I fight with it day by day, and I deal with it finnally.
What specific areas of your project would you like help with?I want to know how could I learn more by this exercise. You know, a beginner don't have much experience.
Community feedback
- @AdrianoEscarabotePosted 4 months ago
Hi Kaine, how’s everything? I think your project turned out great! However, I have some feedback that I think might be useful:
Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the
<picture>
tag instead of importing this as an<img>
or using a div withbackground-image
. Use it to place the images and make the change between mobile and desktop, instead of using adiv
orimg
and set the change in the css withdisplay: none
with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the<picture>
tag and use the html to code to set when the images should change setting the devicemax-width
depending of the device desktop + mobile.Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp
See the example below:
<picture> <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg"> <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;"> </picture>
The rest is amazing.
I hope this is helpful. 👍
0@Kaine665Posted 4 months ago@AdrianoEscarabote Thanks for your feedback, Adriano. It's very helpful.
I know about semantic tags, but there are too many to learn at once. Tags like div and p are easier, so I will learn semantic tags later. The important thing is to write things clearly, including using box, flex, grid, position, etc.
Besides this, I also have a question: Do all of you front-end developers use semantic tags? In my country, semantic tags are not commonly used.
0@Kaine665Posted 4 months ago@AdrianoEscarabote On the other hand, besides semantic tags, what else could I learn from this project?
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord