Skip to content
Submitted 7 days ago

CSS flex

JinchuanWu•60
@JinchuanWu
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

overall good

What challenges did you encounter, and how did you overcome them?

put the div in the center of the web page

What specific areas of your project would you like help with?

basic CSS

Community feedback

  • P
    Boris•3,940
    @makogeborisPosted 7 days ago

    Great job completing your first challenge, here are some suggestions

    • All content should be wrapped within landmarks. Wrap a main tag around the .contentAll
    • Change the width of the .contentAll to max-width and should be defined in rem not %
    • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
    • Font-sizes should be defined in rem not px
    • Change the height: 100vh; on the body to min-height: 100vh;. Using min-height ensures the content can grow beyond the viewport height if necessary, while height would restrict it to exactly the viewport height, potentially causing overflow issues.

    Hope this helps, Good luck!

    0
  • Velasquez Honorio Anthony Enrique•150
    @Anthony-Code6Posted 7 days ago

    The design concept is fine, what you need to improve are the dimensions of the image and also the letters.

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord