Skip to content
Submitted about 2 years ago

css Flex

NikitaBenzin•220
@NikitaBenzin
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I coded the mobile version first, and it's was cold, because the pc version fix harder than mobile xD What did you find difficult while building the project? Which areas of your code are you unsure of?

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello NikitaBenzin, Congratulations on completing this challenge!

    🎨 Here are some tips to improve your component design:

    Your solution its already good, something you can do to improve the card responsiveness is create a media query for the stats section and make each stat number stay in a different row after max-width: 350px using a media query, here's the code for that:

    @media (max-width: 350px) {
.card-info-data {
    display: flex;
    border-top: 0.0625rem solid var(--gray-100);
    padding: 1.5rem 1rem;
    justify-content: space-around;
    flex-direction: column;
}
}

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    1
  • Adriano•38,390
    @AdrianoEscarabotePosted about 2 years ago

    Hi NikitaBenzin, how are you?

    I really liked the result of your project, but I have some tips that I think you will like:

    1- Every page should have one main landmark <main>. So replace the div that wraps the whole content with <main> to improve the accessibility. click here

    2- All page content should be contained by landmarks, you can understand better by clicking here: click here

    We have to make sure that all content is contained in a reference region, designated with HTML5 reference elements or ARIA reference regions.

    Example:

    native HTML5 reference elements:

    <body>
    <header>This is the header</header>
    <nav>This is the nav</nav>
    <main>This is the main</main>
    <footer>This is the footer</footer>
</body>

    ARIA best practices call for using native HTML5 reference elements instead of ARIA functions whenever possible, but the markup in the following example works:

    <body>
     <div role="banner">This is the header</div>
     <div role="navigation">This is the nav</div>
     <div role="main">This is the main</div>
     <div role="contentinfo">This is the footer</div>
</body>

    It is a best practice to contain all content, except skip links, in distinct regions such as header, navigation, main, and footer.

    Link to read more about: click here

    2- Why it Matters

    Navigating the web page is far simpler for screen reader users if all of the content splits between one or more high-level sections. Content outside of these sections is difficult to find, and its purpose may be unclear.

    HTML has historically lacked some key semantic markers, such as the ability to designate sections of the page as the header, navigation, main content, and footer. Using both HTML5 elements and ARIA landmarks in the same element is considered a best practice, but the future will favor HTML regions as browser support increases.

    Rule Description

    It is a best practice to ensure that there is only one main landmark to navigate to the primary content of the page and that if the page contains iframe elements, each should either contain no landmarks, or just a single landmark.

    Link to read more about: click here

    The rest is great!!

    Hope it helps...👍

    Marked as helpful
    1
  • Oussama Taali•250
    @oussamataali97Posted about 2 years ago

    I really liked the result of your project, but I have some tips that I think you will like.

    To further improve the responsiveness of the project, you can do the following:

    img { height: 100%; }

    to prevent the card from growing at lower resolutions. The rest is very good, you did a really great job in this challenge, this background image and the card animations were very good!

    Hope it helps... 👍

    Marked as helpful
    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord