Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

css, display flex, html

@DuvanJR

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@bccpadge

Posted

Hello @DuvanJR. Welcome to Frontend Mentor Community 🎉!!

I have a couple tips to improve your solution.

HTML 📃:

  • Every website should have at least one landmark and for this challenge you can wrap all your content using a <main> tag.
  • There should be one heading on every website as well and you can use <h1> tag

<h1>Improve your front-end skills by building projects</h1>

  • Use the <p> tag to wrap the text

<p>Scan the QR code to visit Frontend Mentor and take your coding skill to the next level</p>

CSS 🎨:

  • Make sure you set font size in rem or em units to make the website more accessible for users. Font size should never be in pixels

  • When building these projects make sure you look at the design and styleguide.md files to get the correct colors.

  • Add the background color to your body

body{
   background-color: hsl(220, 15%, 55%);
}
  • I see that you flexbox throughout your project and you don't need to do that every single element.
  • Flexbox and CSS Grid are used for layouts purposes.
  • If you want to text in the center; you can use the text-align property

Hopes this helps you and don't hesitate to reach out to me if you have any questions✌🏼

Marked as helpful

0

@DuvanJR

Posted

Hello @bccpadge. Thanks for the comments to improve the code, it is a great contribution to my growth in this world of Front-end development, thank you very much

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord