Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
CSS variables and utility classes
What challenges did you encounter, and how did you overcome them?Understanding root variables and how to use them
What specific areas of your project would you like help with?CSS, specifically the root variables and utility classes, as well as general styling.
Community feedback
- @haquanqPosted 3 months ago
Hello @Periodication,
here is my feedback on your solution:
- About your CSS utilities class, consider when does using such class make sense since each of you class has only 1 property (what is the different between this and using the property directly inside other classes - element specific classes).
- Page must have one
main
landmark (read more here)) which means wrap the mot important content of the page inside it. - Use more semantic HTML elements such as
article, section, p
. For example, instead of usingspan
for the body paragraph, you should usep
(span
is generic textual element and it has no semantic meaning - likediv
).
Hope this help, enjoy coding!!
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord