Submitted almost 3 years ago

CSS custom properties, Flexbox, CSS Grid, Mobile-first, native JS

Danny• 200

@DannyLenk

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

Space tourism multi-page website

HTML
CSS
JS

3intermediate

View challenge

Design comparison

SolutionDesign

Solution retrospective

Yes, please. There is a thing that bothers me the most. Why could a hidden attribute not work in some places? For example, on the "destination" and "crew" pages' <article>s it works, whereas on the "technology" one it doesn't. The same problem was with the <div>s containing imgs on the technology page. So, I had to add some changes to the js files.

Community feedback

Godwin Martins• 180

@gmcodes20

Posted almost 3 years ago

Hi @danny, nice one you got here. Maybe you can change the mobile menu hamburger to a pointer. Also, the crew image should be at the bottom on the larger screen and if you can also remove the border-bottom from the image on the large screen

Marked as helpful

Danny• 200

@DannyLenk

Posted almost 3 years ago

Hi, @gmcodes20,

Thank you for taking the time and review my work. Much appreciate! Your comments definitely helped me find mistakes and fix them. Now the website looks more consistent. I would be glad to hear from you further down the road.

Godwin Martins• 180

@gmcodes20

Posted almost 3 years ago

@DannyLenk I'm glad I was able to help. I definitely will love to talk to you again

darryncodes• 6,390

@darryncodes

Posted almost 3 years ago

Hi Danny,

I had this exact same problem and Grace came to my rescue, something I now won't forget:

Here's the info:

the display property overrides the hidden attribute and you have in your code: img, picture { max-width: 100%; display: block; }
try adding: [hidden] {display: none !important;}

All the best

Marked as helpful

Danny• 200

@DannyLenk

Posted almost 3 years ago

Hi, Darryncodes,

Now it works. I never would've guessed it, probably. Big thank you!

Have a good one.

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord