css and html

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted about 1 year ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  HTML 🏷️:

  • Wrap the page's whole main content in the <main> tag.

  • Instead of using the <div> tag to wrap the text, try using the <p> tag. The <p> tag represents paragraph-level content, usually text, and is more semantically appropriate for this purpose.

  • You should not use inline-CSS because it is not a good practice. Instead, you should use an external stylesheet to style your page. By doing this, you will be able to have a better organization of your code and will be able to understand it better.

  CSS 🎨:

  • You've made good progress, but it seems like you've used a lot of position: absolute. If you apply this to every element, it can become challenging to maintain and adjust everything perfectly. Even if it looks fine on your computer, try using the browser zoom feature to see how excessive use of position: absolute can potentially distort your solution. I'd recommend exploring alternatives like margins, paddings, and other layout techniques to achieve your desired design while maintaining flexibility and ease of maintenance.

  • Avoid using position: absolute to center an element as it may result in overflow on some screen sizes. Instead, utilize the flexbox or grid layout for centering. Get more insights on centering in CSS here here 📘.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding!

  Marked as helpful

  2

  ---

  

  sina-ebrahimi•40

  @sina-ebrahimiPosted about 1 year ago

  Thanks @MelvinAguilar

  0