CSS and HTML

Community feedback

• 

  Florent Vandroy•510

  @florent6001Posted about 2 years ago

  Hi !

  Your code are using to much position: static and absolute, you don't need them for this case. The problem with absolute, you can break the page on some screen size.

  For this example, you can use flex-box or CSS Grid. You have a div for every elements on the cards.

  For example, you created a <div class="card"> component then after a div "nftphoto". In this case, the nftphoto is inside the card, so, why don't wrap nftphoto into the card div ?

  By doing that, you avoid nftphoto to be outside the card, same for the next elements. Wrap all the code with the card, visually, they are all inside. The code will be a lot better, and lot more readable.

  Feel free to take a look at other's code for this challenge, and see the difference between every person.

  That's a problem, but i know that you will fix it soon. Good luck for your learning ! See you :)

  Marked as helpful

  0