Travolgi 🍕• 31,420
@denielden
Posted
Hi Shaun, I took some time to look at your solution and you did a great job!
Also I have some tips for improving your code:
- add
main
tag and wrap the card for Accessibility - add descriptive text in the
alt
attribute of the image - To make it look as close to the design as possible add
border-radius: 1rem; and overflow: hidden;
to.container .main-image
class - remove all
margin
fromcontainer
class - remove all
padding
from body - try to use flexbox to the body for center the card. Read here -> best flex guide
- after add
min-heigth: 100vh
to body because Flexbox aligns to the size of the parent container - try to add a little
transition
on the element with hover effect
Overall you did well :)
Hope this help and happy coding!
Marked as helpful
0