Design comparison
Solution retrospective
This one was fairly easy and took me an afternoon. Im trying to be more html semantic friendly with best practices. Any feed back would be greatly appreciated. Minor padding and margin inconsistencies when adjusting page sizes, but barely noticeable. Thank you!
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
- The “car images/icons” in this component are purely decorative; They add no value. So their
alt tag
should be left blank and have anaria-hidden=“true”
to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The headings in your component are being used incorrectly❌ . Since the
h1
heading can only be used once, it is always given to the heading with the highest level of importance. This component has three headings of equal importance, so the best option would be to use anh2
heading since it is reusable and it will give each heading the same level of importance.
- For improved accessibility 📈 for your content, it is best practice to use
rem
for yourfont-size
and other property value. Whileem
is best formedia-queries
. Using these units gives users the ability to scale elements up and down, relative to a set value.
- Implement a Mobile First approach 📱 > 🖥
With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding!🎄🎁
0 - The “car images/icons” in this component are purely decorative; They add no value. So their
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord