CSS and HTML

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Nilanshu Rajmane! 👋

  Good job on this challenge! I really like this onscroll animations. What I can suggest to change is:

  • Change your .cards_container max-width to 38rem and set margin to 2rem 1rem. This way your container will be stretching to the moment it achieve 38rem width. It will be better transition between mobile and design.
  • Since your icons images are decorative your alt text should be provided empty (alt="") so that they can be ignored by assistive technologies, such as screen readers.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Nilanshu V Rajmane•125

  @nilanshu96Posted over 3 years ago

  @tediko Thank you for your feedback! By the way where can I know more about website accessibility? I thought I have to put alt text for all images.

  0

  

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  @nilanshu96 There are many sources, I recommend you to read this first. It is a good basic for accessibility.

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  Looks nice. Transitions from desktop to mobile without issue and it looks like you have all the elements needed. Good Job 🌟🌟 🌟 🌟 🌟

  1

  ---

  

  Nilanshu V Rajmane•125

  @nilanshu96Posted over 3 years ago

  Thank You!

  0