Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Qr code Solution

Diego 30

@DiegoValois

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Lucas 👾 104,420

@correlucas

Posted

👾Hello Diego, congratulations for your new solution!

🎯 Your solution its almost done and I’ve some tips to help you to improve it:

You can reduce the amount of <div> used, for this challenge all you need is a single block to hold all the content (img, h1 and p). You can keep everything inside <main> and remove all the other additional divs that unnecessary in this case.

Here’s a minimal html structure for this challenge:

<body>
<main> or <section> or <div> (not recommended)
<img>
<h1></h1>
<p></p>
</main>
</body>

Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.Anyhow, if we want a more accessible website, then we should use rem instead of px. REM does not just apply to font size, but to all sizes as well.

Here’s a good guide for writing a concise and clean code: https://altcampus.school/posts/writing-semantically-correct-and-clean-html

✌️ I hope this helps you and happy coding!

Marked as helpful

1

Diego 30

@DiegoValois

Posted

@correlucas Wow, thank you so much!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord