Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Css and flexbox

Faheem ismailβ€’ 210

@faheem4545

Desktop design screenshot for the 3-column preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Problem in responsiveness

Community feedback

@MelvinAguilar

Posted

Hi @faheem4545 πŸ‘‹, good job on completing this challenge! πŸŽ‰

Here are some suggestions you might consider:

  • It's recommended to use the semantic tag main. Click here for more information..
  • Instead of using pixels in font size, use relative units of measure like rem or em. The font size in absolute length units (px) does not allow users with limited vision to change the text size in some browsers. Reference.
  • Car icons are for decoration purposes only, so they can be hidden from screen-readers by adding aria-hidden="true" and leaving its alt attribute empty:
<img src="./images/icon-suvs.svg" alt aria-hidden="true" class="header-img">

I hope those tips will help you.

Good job, and happy coding!

Marked as helpful

1

@VCarames

Posted

Hey there!πŸ‘‹ Here are some suggestions to help improve your code:

  • To better identify the main content of you site you will want to encase your entire component inside a Main Element.

  • The car images/icons in this component are purely decorative; They add no value. So their Alt Tag should left blank and have an aria-hidden=β€œtrue” to hides them from assistive technology.

  • The headings need to be in uppercase to better match the FEM design.

  • Implement a Mobile First approach πŸ“± > πŸ–₯

With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

If you have any questions or need further clarification, let me know.

Happy Coding! πŸ‘»πŸŽƒ

Marked as helpful

0

Faheem ismailβ€’ 210

@faheem4545

Posted

@vcarames Thank you for the suggestion bro it is helpfull i am facing difficulty in mobile responsive design i don't know what should be max-width min-width for used in media querry can you help me in media querries

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord