Design comparison
SolutionDesign
Solution retrospective
any feedback to improve my code is welcome........
Community feedback
- @AdrianoEscarabotePosted about 2 years ago
Hello Camilo V. Murt Tamayo, how are you?
I really liked the result of your project, but I have some tips that I think you will like:
1- All page content should be contained by landmarks click here
2- Document should have one main landmark, you could have put all the content inside the
main
tag click here3- Page should contain a level-one heading, you could have changed
p.head
toh1
click hereI noticed that the content is not centered, to fix this we can fix the following:
body { display: flex; align-items: center; justify-content: center; flex-direction: column; min height: 100vh; }
The rest is great!!
Hope it helps...👍
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord