Saulius K.• 560
@TH3RIV
Posted
Hi, @Lubka024!
Your card looks great!
There's no need or is almost impossible to get it 100% accurate without the actual design files that give you all the margins and paddings etc, so don't worry about it as long as it looks close. Now onto a few suggestions for future improvement:
- Your card should be wrapped within
maintags, so it is easier to read the code and screen readers know what is the main content. Landmarks are important. - Try to avoid using
pxvalues and usereminstead. - Try to start using custom CSS properties. While it is not essential here, it is a good habit to develop.
Hope this helps!
Marked as helpful
1
Luba• 20
@Lubka024
Posted
@TH3RIV will do! Thank you!
0
Luba• 20
@Lubka024
Posted
@TH3RIV, i've made some changes, I would love to hear your opinion!
0
Saulius K.• 560
@TH3RIV
Posted
@Lubka024 hey, it looks great. I would center your card on the body element rather than main though.
Just move
main {
height:100vh;
display: grid;
place-content: center;
}
to
body {
min-height: 100vh;
display: grid;
place-content: center;
}
Other than that I have nothing more to suggest. Well done.
0
