css

Community feedback

• 

  Melvin Aguilar 🧑🏻‍💻•61,140

  @MelvinAguilarPosted 11 months ago

  Hello there 👋. Good job on completing the challenge !

  I have some suggestions about your code that might interest you.

  • With heights, it's better to let the content define the height of the component. If you need to set a height, it's preferable to use min-height instead of height. For widths, it's better to define them with max-width so that when screen dimensions change, the component adapts accordingly.

  • Enhance accessibility and organization by using semantic elements like <main> and <footer>.

  • Maintain a clear heading hierarchy, starting with <h1> and progressing through heading levels. Source 📘

  • Apply box-sizing: border-box to include padding and border in width and height calculations. Details here 📘.

  • Optimize code organization by adding font-family: "Outfit", sans-serif; to the body instead of individual <p> and <h*> elements.

  I hope you find it useful! 😄 Above all, the solution you submitted is great!

  Happy coding! 🎁🎄❄️

  0