Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


how do you make height responsive. and whats the best way to make your width responsive

Community feedback

@MelvinAguilar

Posted

Hello there πŸ‘‹. Good job on completing the challenge !

I have some suggestions about your code that might interest you.

  • With heights, it's better to let the content define the height of the component. If you need to set a height, it's preferable to use min-height instead of height. For widths, it's better to define them with max-width so that when screen dimensions change, the component adapts accordingly.
  • Enhance accessibility and organization by using semantic elements like <main> and <footer>.

  • Maintain a clear heading hierarchy, starting with <h1> and progressing through heading levels. Source πŸ“˜

  • Apply box-sizing: border-box to include padding and border in width and height calculations. Details here πŸ“˜.

  • Optimize code organization by adding font-family: "Outfit", sans-serif; to the body instead of individual <p> and <h*> elements.

I hope you find it useful! πŸ˜„ Above all, the solution you submitted is great!

Happy coding! πŸŽπŸŽ„β„οΈ

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord