CSS グリッドを使用したレスポンシブランディングページ

Community feedback

• 

  Dimitar Radev•930

  @Mitko90Posted 11 months ago

  Hi, nice solution.

  It looks great. Pixel perfect

  Maybe you can check some suggestions I have for you:

  • You used three times the <h1> heading. This heading should only be used once. Maybe change it to <h2> as it can be reused. Of course every page should have an h1 heading so I suggest adding a visually-hidden one to the page, so it doesn't generate an accessibility report.
  • Your buttons should direct the user to a different part or page of the site. So maybe switch the <button> with the <a> tag.

  I had the exact same mistakes when I did this challenge so I redid it with the changes. You can, if you want, check both of my submissions here and here.

  Above all the solution you submitted looks great.

  Happy coding.

  Marked as helpful

  1

  ---

  

  P

  amakura-411•60

  @amakura-411Posted 11 months ago

  @Mitko90

  Thank you for the advice! 🙏

  I've implemented the changes suggested in the code:

  You used three times the <h1> heading. This heading should only be used once. Maybe change it to <h2> as it can be reused. Of course every page should have an h1 heading so I suggest adding a visually-hidden one to the page, so it doesn't generate an accessibility report.
  

  As you recommended, I changed <h1> to <h2>. Additionally, I visually hid the <h1> using CSS.

  Your buttons should direct the user to a different part or page of the site. So maybe switch the <button> with the <a> tag.
  

  I added an <a>tag to the button.

  Lastly, thank you for the advice!!😊 Thanks to you, the code has improved!

  0