CRUD/Functional Ecommerce Product Page

Community feedback

• 

  Suleman•750

  @legion40216Posted about 2 years ago

  Bro Awesome work... keep it up

  1

  ---

  

  Jeffrey Tuason•550

  @Tuason066Posted about 2 years ago

  Hi @legion40216,

  Thank you so much for appreciating my efforts.

  Happy coding bro 🎶👨‍💻✨🔥

  1
• 

  Sahand Masoleh•1,210

  @sahand-masolehPosted about 2 years ago

  Hi Jeffrey, great job!

  You have deactivated Github pages for this repo so I can't see what was wrong. But you typically have to set a 'homepage' property in your package.json, otherwise your relative links don't point to the right address.

  Usually when everything works but the images, it's a path problem.

  1

  ---

  

  Jeffrey Tuason•550

  @Tuason066Posted about 2 years ago

  @sahand-masoleh

  Hi Sahand,

  I purposely removed the GitHub environment/pages/homepage and the scripts for gh-pages

   "predeploy": "npm run build", 
  "deploy": "gh-pages -d build",
  

  because it didn't work so my option is to remove them and instead use the GitHub pages I used Netlify.

  I just found this...

  from freeCodeCamp

  At first glance, everything seems to be working fine. But when you try refreshing the page or navigating through the browser itself, you'll keep getting 404 errors.

  Why does this happen? Because GitHub Pages does not support browser history like your browser does. In our case, the route https://tomerpacific.github.io/starter-project/about doesn't help GitHub Pages understand where to point the user (since it is a frontend route).

  To overcome this problem, we need to use a Hash Router instead of a Browser Router in our application. This type of router uses the hash portion of the URL to keep the UI in sync with the URL.

  Here's the link for the blog I hope it also helps you.

  Thank you so much for the response.

  0

  

  Sahand Masoleh•1,210

  @sahand-masolehPosted about 2 years ago

  @Tuason066 Ahh yeah, GitHub pages doesn't redirect, there are tricks for it, but I personally jusy use Netlify which does.

  But where are you using routing in this page? It's just a single page, isn't it? 🤔

  2

  

  Jeffrey Tuason•550

  @Tuason066Posted about 2 years ago

  @sahand-masoleh yeah it's just a single page, I am just using it to practice how to use react-router because this will be helpful in the future. 😅

  2