Crowdfunding product page Vanilla JS, Sass, Flexbox

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Michael Kret! 👋

  Congrats on finishing another challenge! Your solution looks very good and also responds well. Here's my few tips:

  • Add :focus pseudo class to interactive elements like anchors, buttons etc. Use outline property to make your website more accessible to keyboard users. Focusable elements like anchor, buttons or inputs they have applied default :focus pseudo class with outline property. These default styles are subtle and hardly visible tho. Furthermore every browser has a slightly different default style for the outline, so you probably want to change the default style. Read more about why we should change focus styles.
  • After opening a modal with my keyboard the focus isn't in modal and I can't select modal options right away. Take a look at this great @brasspetals solution (link). She implemented focus trap in her project to - in short - prevent focus to go outside the modal once the modal is opened.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Anna Leigh•5,135

  @brasspetalsPosted over 3 years ago

  @tediko Thanks for the mention! 😊

  @atekron Hi, Michael! 👋 I'm still having issues with my focus trap likely due to the crazy way I've managed my radio inputs. However, if you would like to try and create one as tediko suggested, this video from Udacity's accessiblity course explains it fairly well.

  Congrats on completing this challenge - it was a tough one! 🎉 Happy coding!

  0

  

  Michael Kret•470

  @atekronPosted over 3 years ago

  @brasspetals thanks, I will fix all those :focus issues and will watch course, just need some break from this project

  0