Crowdfunding Product Page using JSONServer and ReduxToolkit
Design comparison
Solution retrospective
I decided to add a backend for this project using JSONServer and Heroku, to store the amount of items left, progress bar info etc. I also implemented localstorage to store whether the project has been bookmarked or not. Please review this project and let me know your honest opinions. Thank you in advance!
Community feedback
- @mattari97Posted about 2 years ago
Hello Clarence, what's up ? Good job completing this challenge 🎉🎉🎉 All basic styles (colors, typography, etc...) seems to be correct so nice work!
I have 3 advices for you:
- You should add the property
cursor: pointer
to all interactive elements, in this case all the links and buttons. This is a small detail that goes a long way for better user experience.
Now to fix the issues in your report:
-
You should wrap both sections (home & about) in a
main
tag. You did it already for the header which is great! -
Same for the
<div id="wrongValue" class="notification"></div>
. The parent container should be anaside
element. It is the landmark you should use for all the elements outside ofheader
,main
orfooter
.
Have a nice day/night. Peace 😊
Marked as helpful1@clarencejuluPosted about 2 years ago@AntoineC-dev You are right bro...I need to add these. It is essential to make sure html is sematic. Thank you so much bro. It's always great to hear from you, do have a nice day/night!
1@clarencejuluPosted about 2 years ago@AntoineC-dev I just fixed the issues that you outlined in my HTML. Thanks as always. I really appreciate your input bro...
1 - You should add the property
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord