@pikapikamart
Posted
Hey, great work on this challenge, the layout is good in desktop and it resizes well when going in mobile state.
The bookmark seems working fine in my end here and that appearance of modal from bottom is a good touch in terms of animation.
My suggestions would be that
-
I think for the select reward buttons, maybe
a
tags are not the best choice in here since it makes the browser jumps up since it is an anchor tag. But still you can use but maybe adding apreventDefault
method on them so that it won't do that such effect. -
Removing the padding left and padding right of the
.head
selector in mobile state so that it is aligned to the main padding of the body. Also removing themargin-left
in the.logo
as well so that they will not be pushed into the right side. -
Adding a little bit of space in the
101 left
in the modal in mobile state. So that it won't be touching the text above it.
Overall, great job on this one and thank you as well for the compliment, really means a lot ^^
@tushar416
Posted
@pikamart Thanks for your helpful suggestions. I updated my code. I think it looks better now.
@pikapikamart
Posted
@tushar416 @bimalmagar10 That was quick though and thank you for considering it and it looks very good, even before^
@tushar416
Posted
@pikamart thank you! 😊👍