Design comparison
Solution retrospective
This project took me 37 hours of coding, thinking and searching for answers. I learned how to work with dialog html element and I practiced a lot of code with DOM manipulation. I created an object with my product items that is dynamically displayed inside my dialog element. From now on I will try to go further and start coding intermediate challenges.
Community feedback
- @clarencejuluPosted about 2 years ago
I can tell you worked hard during this project and I must say; Welldone!
One thing I'd like to add is only a suggestion to improve user experience and is not necessarily an issue. It would be nice if clicking 'select reward' takes you to the corresponding modal section. You can do this by using 'scrollIntoView()'. 'scrollIntoView()' would scroll the page to the corresponding id area.
You could do something like this:
if(selectRewardClicked){ document.getElementById(id).scrollIntoView(); }Feel free to reach out to me if you have any questions; Goodluck!
Marked as helpful1@Pawel-GnatPosted about 2 years ago@clarencejulu Thanks for your comment. Your advice is really great, because I was thinking how I can do this kind of improvement in an easy way. I didn't know that scrollintoview API. Great! Today I learned sth new :)
0@clarencejuluPosted about 2 years ago@Pawel-Gnat You are welcome bro! Have a great day...
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord