Design comparison
Solution retrospective
Feedbacks are appreciated
Community feedback
- @steventobenPosted almost 4 years ago
I haven't looked at the code but the implementation is nice. Just one thing I noticed that should be changes is with modals and dialogs. A modal should take over your screen and hijack the scrolling. Essentially when a modal or dialog is opened you shouldn't be able to scroll the main page that's behind the overlay. Modals and dialogs require an action to be made and you shouldn't be able to interact with any other element on the page including scrolling the entire page or pressing buttons and stuff like that. The popup is the thing that requires immediate attention so it needs to be interacted with and stay in a fixed place until you interact with it.
1@vishalnirmalPosted almost 4 years ago@steventoben As the length of the modal is more than the view-height scrolling is required. And if i stopped scrolling only a part of modal will be accessible. Can you suggest some solution for it. Thanks.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord