Credit App using CSS FlexBox,Javascript, and HTML!

Community feedback

• Account deleted

  For me your JavaScript Code is not totally messy because you add some comments and you maintain the Dry principle (Don't Repeat Yourself) which is big plus for that and for not giving up to the challenge.

  I recommend learn the modules in a JavaScript. Basically you will create another new JS file so that the file you created will be included in the JS main file if you imported that file to the main.

  if you learn modules. the getElementById with variables name you declared in a main JS file you can create a new JS file for that ex

  // Another File 
  const obj = {
  cardName: document.getElementById("card-name"),
  cardNum: document.getElementById("card-num"),
  }
  export default obj;
  
  //main file JS
  import obj from path;
  
  // you can use the selectors even though 
  // not declared in the main but in the other file
  obj.cardName
  obj.cardNum
  

  it makes your main file more readable and not look messy if you did this because what if the project becomes more big and you add some features because of that the main file will be bloated and hard to read but you will figured out by yourself when to used module if you learn modules in JavaScript

  .getByElementClass just ignored that kind of syntax in a real-world we never used that selector we always used getElementById , .querySelector and querySelectorAll

  Marked as helpful

  1

  ---

  

  Miguel Gomez•110

  @MikeProducePosted about 2 years ago

  @okayda Hey jhon thanks for your feedback I had no idea that you could import one JS file to another one! so thank you for that I will definitely be including that next time.

  0