Creative-single-page-site using Flexbox and CSS Grid / mobile-first.
Design comparison
Solution retrospective
Overview: The layout of this site looked fairly challenging with the overlapping elements, so I chose it in order to practice using CSS grid. The main struggle I had was getting the tablet / desktop layouts to look correct with CSS grid. I managed to get my site somewhat close to the original design, though not 100%. I used the mobile first approach.
Things that could be improved / worked on:
-
The slider only works for the images, (I did not notice the changing text until later) I only managed to get the text to change with the pictures using basic if / else statements, but I ran into problems with the logic of the code and ended up having the text match with the wrong image after clicking a certain number of times.
-
The box that contains the text 'Brand naming & guidelines' is too small for the desktop size as I had some problems getting the design to match up with CSS grid.
-
The desktop site and its content has a
max-width
and does not stretch out on larger screens. I forgot to take this into consideration when defining the basic HTML structure and making the grids. If I were to attempt this again, I would redo the main section with a better grid system that would stretch out to the edge of the browser rather than having everything centered.
General Questions:
- When is it better to use the
<picture>
tag instead of an<img>
tag? - Should rem be used for height or width of elements instead of px, I'm aware that rem is preferred over px for font-sizes due to accessibility.
- Is there a way to add a bold font effect on hover to
<a>
links without them shifting because of the difference in size?
Any sort of feedback would be greatly appreciated!
Community feedback
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord