Design comparison
Solution retrospective
Creacion de una NFT card usando html5 y css3 Se hizo lo mas parecido posible a la del ejemplo en el reto
Community feedback
- @denieldenPosted almost 3 years ago
Hi Rolando, great job!
Adding
main
tag for AccessibilityTry to remove all
margin
fromcontenedor
class and use flexbox to the body for center the card.Also set
heigth
of body to100vh
because Flexbox aligns to the size of the parent container.Hope this help and happy coding :)
Marked as helpful0@rolando-17Posted almost 3 years ago@denielden ohhh thanks i will use your mentions on my future proyects thankyou
1 - @NaveenGumastePosted almost 3 years ago
Hay ! Good Job Rolando
These below mentioned tricks will help you remove any Accessibility Issues
-> Add
Main
tag after body like it should be your container. For 1st heading orh1
tag, use header tag and then inside the header put yourh1
orh2
etc . But use header tag only once in main heading element.Keep up the good work!
Marked as helpful0@rolando-17Posted almost 3 years ago@Crazimonk main it gona be mi first container? thats what you are telling me or am confused
1@NaveenGumastePosted almost 3 years ago@rolando-17 yes that's right you have to make `main tag class="container" and the div class="wrapper" and then your content
0 - @ingnicolaspjPosted almost 3 years ago
Buen trabajo pero veo que faltan componentes como el perfil, las fuentes tipos de letras etc
Marked as helpful0@rolando-17Posted almost 3 years ago@ingnicolaspj ah si me falto eso en un rato mas lo pongo y lo vuelvo a subir
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord