Creating-QR-code-component-layout-challenge-using-CSS-flex-box

Community feedback

• 

  T

  Chamu•13,130

  @ChamuMutezvaPosted over 1 year ago

  Hi AHMEDKH24

  So far so good with your challenge, here are a few things that I managed to pick after going through your work:

  1. I see you have used a footer element, that is good since it is a semantic html element that can be used by search engines and assistive technology. The other element that I believe should be in a site is the main element - it contains content that is central to the purpose of the site. Divs and spans should be used as elements of last resort.
  2. The alt value should not contain words such as image, icon, picture etc as those words will be automatically announced by screen readers - including them will be a matter of repetition to assistive technology users.
  3. For font sizes, I encourage you to use rems instead of px. Read the following article for the reasons. Font size

  4 . Do a search about modern css reset stylesheets. One most common one is by Andy Bell. 5. Try to leave some space between the body and the children. Check it on small devices.

  Marked as helpful

  1

  ---

  

  Ahmedkh24•20

  @Ahmedkh24Posted over 1 year ago

  @ChamuMutezva Thank you so much for your valuable feedback. I really appreciate that.

  0
• 

  NperTen•60

  @npertenPosted over 1 year ago

  Hi Ahmed. Good job at your first project.

  There was shadow behind the QR code card in the design file. You missed that. The width of the card was 320px but you did 380px. And you don't have to use hyphens (-) in your project name.

  Marked as helpful

  0