Creating components using CSS

Community feedback

• 

  Micah Sells•100

  @MicahtronPosted 5 months ago

  Great work, however it looks like you're using id attributes for the styling (id="weight-700"). This is better done using classes since you could have multiple elements on a page with that same styling class such as cards, headings, teasers, etc. The id attribute names are meant to be unique and used only once per page.

  Since this is a single component by itself it doesn't matter too much, but if multiple QR cards of this type were used in a full page this would need to be changed to classes. Plus using classes for your styling system attributes makes them useable on any element so it wouldn't be limited to just this card type.

  Marked as helpful

  0

  ---

  

  Abolaji Nofiu•40

  @JOAN-96Posted 5 months ago

  @Micahtron Thanks for the awesome comment. My reason for using id attribute instead of class was because I wasn't using the card styles in multiple places. Thanks for the observation and advise, I would put in mind when doing the next challenge.

  0