Submitted over 2 years ago
Created using HTML5 , CSS, Flexbox, CSS Grid, mobile first approach
@nkirukka
Design comparison
SolutionDesign
Solution retrospective
Any idea how I can remove the grid gaps in the gallery section on mobile screen? I tried using the gap property but it didn't work.
Community feedback
- @miroslavdurinPosted over 2 years ago
Hello, you can try adding
display: block
in.mobile-imgs
class. Something like this should work:.mobile-imgs { width: 100vw; display: block; }
Marked as helpful0@nkirukkaPosted over 2 years ago@miroslavdurin it worked! Thank you soπππ
1 - @DreamCoder7Posted over 2 years ago
Hey, Nkiruka Ebeleπ
Great effort on this challenge!π
A few things I'd like to suggest are,
- Displaying the images from your html using img tag isn't problematic but you can take the advantage of background-image: url('..') to switch between the mobile version of your img to desktop version img. This way you can a void the repetition.
- It's more interesting if you add a transition properties on the anchor tag <a></a> in your transform section
- I also notice that the modal windows which is toggle or fire by clicking the hamburger menu it's not set to a high z-index value, In <section class="design-photography"></section> it overlap by the text. So you can quickly fix that and also adding a backdrop can help the modal to stand out from the page not relevant but also good practice.
Hope you find this helpful!π
Happy codingπ
0@nkirukkaPosted over 2 years ago@redstorm-hub thanks a lot for the feedback, will work on those
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord