Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Created using HTML5 , CSS, Flexbox, CSS Grid, mobile first approach

Nkiruka Ebeleβ€’ 90

@nkirukka

Desktop design screenshot for the Agency landing page coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any idea how I can remove the grid gaps in the gallery section on mobile screen? I tried using the gap property but it didn't work.

Community feedback

Miroslavβ€’ 180

@miroslavdurin

Posted

Hello, you can try adding display: block in .mobile-imgs class. Something like this should work:

.mobile-imgs {
  width: 100vw;
  
  display: block;
}

Marked as helpful

0

Nkiruka Ebeleβ€’ 90

@nkirukka

Posted

@miroslavdurin it worked! Thank you so😁😁😁

1
Abreham Nigussieβ€’ 470

@DreamCoder7

Posted

Hey, Nkiruka EbeleπŸ‘‹

Great effort on this challenge!πŸ‘

A few things I'd like to suggest are,

  • Displaying the images from your html using img tag isn't problematic but you can take the advantage of background-image: url('..') to switch between the mobile version of your img to desktop version img. This way you can a void the repetition.
  • It's more interesting if you add a transition properties on the anchor tag <a></a> in your transform section
  • I also notice that the modal windows which is toggle or fire by clicking the hamburger menu it's not set to a high z-index value, In <section class="design-photography"></section> it overlap by the text. So you can quickly fix that and also adding a backdrop can help the modal to stand out from the page not relevant but also good practice.

Hope you find this helpful!😊

Happy coding😎

0

Nkiruka Ebeleβ€’ 90

@nkirukka

Posted

@redstorm-hub thanks a lot for the feedback, will work on those

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord