Design comparison
Solution retrospective
Hello everyone, I've made this solution by using SCC. Please check my code and feel free to write a feedback
Community feedback
- @NaveenGumastePosted almost 3 years ago
Hay ! MajidiyM Good Job on challenge
These below mentioned tricks will help you remove any Accessibility Issues
-> Add Main tag after body
<main class="container"></main>
->[Bad value images\icon-view.svg for attribute src on element img: Backslash () used as path segment delimiter.] This means you can't & should not use backslash while linking a file.
-> Learn more on accessibility issues
If this comment helps you then pls mark it as helpful!
Have a good day and keep coding 👍!
Marked as helpful0 - @ashiqfuryPosted almost 3 years ago
Fantastic work.
- I noticed some color issues in corners of the
.comp_img
when hovering, you can fix this by reducing theborder-radius: 8px
. Reduce 2px from the parent container - You forget the double
box-shadow
effect in the.component
I hope my suggestions will help to improve your code. Thank you. 🙌
Marked as helpful0 - I noticed some color issues in corners of the
- @RioCantrePosted almost 3 years ago
Hello there! Good job in this challenge. Viewing the solution, I think you should consider the following as well…
- Include description with the
alt
in image tags. Like this line<img src="images\image-equilibrium.jpg" alt="" />
- Increase the size of the main header which is in the
.container .component .comp_title span
into30px
- Include the hover state in the rule set of
container .component .comp_profile .profile_name p span
- Pay attention for the usage of "/" , use it in correct way. From this
<img src="images\image-equilibrium.jpg" alt="" />
into<img src="images/image-equilibrium.jpg" alt="" />
Above all, Well done! Keep it up and Hope this is helpful!
Marked as helpful0 - Include description with the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord