Created responsive qr-code-component using html and Css

Community feedback

• 

  cesar hernan ruscica•320

  @hernanruscicaPosted about 2 years ago

  Hello Swardha Sawant, first of all, congratulations for completing the challenge, even if it is an easy one, it is important for being one of the first. Visually it is very similar to what is required. About the code, I tell you some suggestions:

  1. since it is supposed to be a component, it would have been better if the component itself was aligned with margin attribute, instead by the parent "body" container.
  2. The class name "Container" is very generic and into a larger code, it would generate class interference.
  3. I would like to make the selection of the elements in the css code, by classes name instead generic selector like "h1". But overall, it's a well-done project. Greetings and until next time

  Marked as helpful

  0

  ---

  

  Swardha Sawant•70

  @SwardhaPosted about 2 years ago

  @hernanruscica hey.... thanks for your feedback, I would love to appreciate your suggestions on high authority...I will keep that reminder while coding next time for sure.

  1