Boris• 2,870
@mkboris
Posted
Nice work BarapidoWillem, here are a few things to review
- Use a separate file for your CSS
- Its not good practice to wrap every element in
div
because divs aren't semantic. Use Semantic Elements. Thep
tags don't need to be wrapped indiv
. The 'HTML & CSS foundations' text is a heading element not alabel
. The name 'Greg Hopper' is not a heading element but ap
. Learn about Heading elements - Wrap a
footer
around the attribution - Font-size should be written in
rem
not px - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
0