Design comparison
SolutionDesign
Solution retrospective
What are you most proud of, and what would you do differently next time?
i'am starting to learn how to use properly the display, align-items and justify-content
What challenges did you encounter, and how did you overcome them?how to apply properly the display, align-items and justify-content
What specific areas of your project would you like help with?i would like to ask help for the best practices because as of now there are times that i'am confuse on how to use the css
Community feedback
- @mkborisPosted 3 months ago
Nice work BarapidoWillem, here are a few things to review
- Use a separate file for your CSS
- Its not good practice to wrap every element in
div
because divs aren't semantic. Use Semantic Elements. Thep
tags don't need to be wrapped indiv
. The 'HTML & CSS foundations' text is a heading element not alabel
. The name 'Greg Hopper' is not a heading element but ap
. Learn about Heading elements - Wrap a
footer
around the attribution - Font-size should be written in
rem
not px - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset. This will help reset a list of default browser styles.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord