Design comparison
Solution retrospective
What was difficult :
- Using an SVG.
- Some margins between the cards.
Community feedback
- @correlucasPosted about 2 years ago
👾Hello Sam, congratulations on your new solution!
Great code and great solution! I did this challenge too and know how hard it is to set up this
grid layout
. I think you've done a really good job building everything! Here are some tips for you:The html structure you’ve used here works, but if you want to make this even better, you can replace the
<div>
you’ve used to keep the blocks and replace with some better html markup and semantic, for example, the main block can be wrapped with<main>
and each testimonial card with<article>
, then you can use a tag that not everyone knows, for the paragraph containing thequote
you can replace the<p>
with<blockquote>
that is tag the describe exactly its content.This article from Freecodecamp explains the main HTML semantic TAGS: https://www.freecodecamp.org/news/semantic-html5-elements/
✌️ I hope this helps you and happy coding!
Marked as helpful0 - @cjay44Posted about 2 years ago
Hey, This is great! It looks like this would be a perfect project to utilize grid - for the col-span, and row-span properties!
To get the margins consistent for each card, you should look into the "gap" property. It comes in handy, for setting "margins" for children of flex and grid containers.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord