Design comparison
Solution retrospective
design and code structure
What challenges did you encounter, and how did you overcome them?visibility of images at the live page, need to pay more attention on it
What specific areas of your project would you like help with?project preperation and planning of solutions, media quaries
Community feedback
- @danielmrz-devPosted 7 months ago
Hello there!
Congrats on completing the challenge! ✅
Your solution looks excelent!
I have just one suggestion:
📌 To improve semantic clarity, opt for
<h1>
over<h5>
for your main title.It's more than just text size — it's about structuring your content effectively:
<h1>
to<h6>
are used to define HTML headings, with<h1>
being the most significant.- Stick to one
<h1>
per page for the main title, and maintain the titles hierarchy with<h1>
,<h2>
<h3>
, and so on.
While these adjustments might not alter the visual appearance much, they significantly enhance semantic clarity, SEO optimization, and accessibility.
Hope this suggestion proves helpful! Keep up the great work!
Marked as helpful1@erdling2Posted 7 months ago@danielmrz-dev thanks for giving that hint and your feedback
0 - @AnaBeatrizA-SilvaPosted 7 months ago
Sorry, but I'm curious, why do you use scss?
Is it easier or did you learn this way?
I dont know if its beacause the sccs, but your HTML code seem a little confiusing. Why wrapping a p tag inside a div, or use the form tag?
And, what it is that title tag?
0@AbdullahHamadaxPosted 7 months ago@AnaBeatrizA-Silva
You can think of SCSS as an upgraded version of CSS, which typically means that you learn additional features.
His HTML code is normal, SCSS doesn’t touch the HTML code. He used a form tag to contain the HTML & CSS Foundations and made it a header inside a button when you click on it , it leads into a link ( it leads to this challenge website. )
He used the title tag for the Greg Hooper. ( you can use a p tag instead. )
As for why he wrapped the p inside a div, I don’t know how to explain it to you, but all I can say is that, you’re always going to need to wrap elements inside divs.. especially when using Flexbox for the sake of layout.
1@erdling2Posted 7 months ago@AnaBeatrizA-Silva thanks for questioning, i prefer to wrap text(<p>) inside a div to handle it with flexbox not only for positining, you can also add styles for it by not infecting the p-tag itself just leaves you more options for styling.
I use scss for styling because its structured like the html and more easy to follow along while writing besides some additional features like Abdullah mentioned.
@AbdullahHamadax for commenting, i could not explain it in a better way
2
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord