Country facts app

Community feedback

• 

  Bryan Fonseca•60

  @BryanFonsecaPosted over 2 years ago

  Hi @adeleke5140. Your work looks great! I was browsing your code and noticed you used a regular expression on your component which renders the country info. My approach was to use the internationalization API, it works out of the box and does it according to the browser language, with code like this you get a nicely formatted string: new Intl.NumberFormat(navigator.language).format(your_big_number) Also, I see you used one CSS file for all your components, how did it go? In my solution I opted for splitting them using CSS Modules so that I kept my style declarations scoped to only one component per file.

  Marked as helpful

  1

  ---

  

  Kakeru•265

  @adeleke5140Posted over 2 years ago

  @BryanFonseca Hi Bryan

  Thanks for the feedback. This was my very first React project after taking a crash course to it's...less than optimized. I just wanted to build something and it was fun for that.

  I haven't heard of the internationalization API so thank you for mentioning that.

  Regarding CSS, I just like writing all my CSS in one place. For my next projects though, I'm gonna be leveraging styled components because they are pretty nifty.

  You can see what I'm up to on my Twitter, @adeleke5140. it would be great to connect.

  0
• 

  Medjahdi Islem•275

  @IslemMedjahdiPosted over 2 years ago

  Hello @Kakeru, I love your work, good job. I have just some improvements to say, It would be better if you add pagination becuse your website looks too long and fix the flag images ( width and height) I can't see my full country flag :D check my work: https://country-finder-medjahdi.netlify.app/ Have a nice day!

  Marked as helpful

  1

  ---

  

  Kakeru•265

  @adeleke5140Posted over 2 years ago

  @IslemMedjahdi Thank you. I haven't heard about pagination before but will look into it. I guess my initial attempt was just to render an infinite list of country images but that definitely wasn't the best.

  The flag images was something I really struggled with and I will improve them.

  0