Country Codex

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted over 2 years ago

  Hi Yago, great work on this challenge!

  Here are a few tips for improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • to make it look as close to the design as possible add the second color of background to div of card and add border-radius: .5rem and overflow: hidden
  • to make all flag images the same height use the object-fit: cover property to img element
  • instead of using px use relative units of measurement like rem -> read here
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • for the name of country use h2 instead simple p because it's the title of card
  • you can use ul instead of multiple p for the details of country
  • in the details page the Border Countries isen't align horizontally

  Overall you did well 😉

  Hope this help and happy coding!

  Marked as helpful

  0