Countries Switcher with styled components and React JS

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  Hello Laurenxx, You have done a good work! 😁

  Some little tips to improve your code:

  • add header tag and wrap the navbar for improve the Accessibility
  • add main tag and wrap the main content of page for improve the Accessibility
  • use article tag instead of a simple div to the container card of countries for improve the Accessibility
  • add descriptive text in the alt attribute of the images not flag for all
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the article tag container of descriptive text of card
  • instead of using px or % use relative units of measurement like rem -> read here
  • use one class to body to change the all theme color of app
  • after, add transition on the body to smooth the change theme color
  • use ul element for the details text of country instead of multiple p
  • if you want to use the title for the href attribute you have to parse it in url, it can give problems creating links with empty spaces or special characters
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  0

  ---

  

  Laurenxx•850

  @awsmPuffPosted almost 2 years ago

  @denielden Thank you very much!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted almost 2 years ago

  @awsmPuff You are welcome and keep it up :)

  0