Countries Rest API - React, React Router, SCSS, localStorage

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello Terjee, You have done a good work! 😁

  Some little tips to improve your code:

  • add descriptive text in the alt attribute of the flag images and not a flag word for all
  • instead of using px use relative units of measurement like rem -> read here
  • add transition on the body to smooth the change theme color
  • use ul element for the details text of country instead of multiple p
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient
  • to make all flag images the same height use the object-fit: cover and aspect-ratio: 3/2 properties and remove height

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  terjeee•180

  @terjeeePosted about 2 years ago

  @denielden Thank you so much for such a detailed review!

  I'm not going to lie; I skipped on properly styling the images as I wanted to move on to another project. Your suggestion made for such an easy fix, something I'll take with me into other projects. images can be a hassle to work with. Now I have another trick up my sleeves. Again, thank you.

  This is actually the first project I've used px instead of rem. I did it because I added a line of code to the html{} that automatically changes the font-size based on vw. For some weird reason I was under the impression that using rem would mess that up. I've already switched back!

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @terjeee it was a pleasure :) and keep it up!

  0