Countries rest Api app with React, React Router, mobile first

Community feedback

• 

  Simon Davis•505

  @SkidragonPosted over 3 years ago

  Hi @tomsky90, nice job on the dark mode and filtering. I do recommend to setup prettier to format your code to make it look nicer and not worry about formatting code. Also the components need to be simplified more, for example:

  const HomePage = ({
      error,
      setError,
      darkMode,
      countriesListData,
      countriesDataForDisplay,
      setCountriesDataForDisplay,
      selectValue, 
      setSelectValue,
      inputValue,
      setInputValue,
  }) => {
      return ( 
          <div>
              <Form  
                  setError={setError}
                  darkMode={darkMode}
                  countriesListData={countriesListData}
                  countriesDataForDisplay={countriesDataForDisplay}
                  setCountriesDataForDisplay={setCountriesDataForDisplay}
                  selectValue={selectValue}
                  setSelectValue={setSelectValue}
                  inputValue={inputValue} 
                  setInputValue={setInputValue}
              />
  

  this is like saying in vanilla js land Form(setError, darkMode, countriesListData, countriesDataForDisplay, setCountriesDataForDisplay, selectValue, setSelectValue, inputValue, setInputValue), I as a developer of this re-usable component wouldn't want to deal with. It needs to be more generic of a form. For example:

  <Form
  isDarkMode={true} //the "is" tells me it's a boolean
  data={[]}
  onSubmit={() => {
  // fetch, set your countries, set errors, and set load here
  }}
  onInputValueChange={() => {}}
  onSelectValueChange={() => {}}
  

  This way you can re-use the component in more than one place.

  0

  ---

  

  tom•175

  @tomsky90Posted over 3 years ago

  @Skidragon I thought it was getting a little bit out of control but didn't know how to sort it. Thank you for your advice, I will bare that in mind and try to implement it.

  0
• 

  P

  Bruno Campos•80

  @besopmacPosted over 3 years ago

  This comment was deleted over 3 years ago

  0

  ---

  

  tom•175

  @tomsky90Posted over 3 years ago

  @besopmac I'm not to sure what you mean.

  0

  

  P

  Bruno Campos•80

  @besopmacPosted over 3 years ago

  @tomsky90 Nevermind.

  0
• 

  P

  Patrick•14,265

  @palgrammingPosted over 3 years ago

  you might want to work on some hover effects for the cards and the back button but otherwise you have a good start to this

  0

  ---

  

  tom•175

  @tomsky90Posted over 3 years ago

  @palgramming thank you for advice. much appreciated :)

  0