Countries

Community feedback

• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hello Nizar, You have done a good work! 😁

  Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • add descriptive text in the alt attribute of the flag images and not a flag word for all
  • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
  • instead of using px use relative units of measurement like rem -> read here
  • not use the css inline style inside html but create a class inside the css stylesheet
  • use one class to body to change the all theme color of app
  • after, add transition on the body to smooth the change theme color
  • use ul element for the details text of country instead of multiple p
  • if I type a query that doesn't give any results, nothing happens, try adding a "no results" message
  • I would also add a query reset button, I find it very convenient

  Keep learning how to code with your amazing solutions to challenges.

  Hope this help 😉 and Happy coding!

  Marked as helpful

  1

  ---

  

  NizarMjr•390

  @NizarMjrPosted about 2 years ago

  @denielden Thank you very much

  1

  

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  @NizarMjr you are welcome!

  1