Countries App using React, TypeScript and Sass

Community feedback

• 

  P

  tediko•6,680

  @tedikoPosted over 3 years ago

  Hello, Han! 👋

  Well done on this challenge! Your solution responds well. Here's my suggestions:

  • Read about semantic. Semantic elements lead to more consistent code, they are easier to read and improve accessibility.
  • You should use <h1-h6> heading tag in .header__heading and .card__heading instead of paragraphs.
  • Since your .header__theme-switch triggers some action from Javascript use <button> element instead of div.

  Good luck with that, have fun coding! 💪

  1

  ---

  

  Han•515

  @iwaskoreanPosted over 3 years ago

  @tediko Hello, tediko! 👋

  I really appreciate your suggestions. I know what semantic elements are but I always use div element 😂. I should use them.

  Thanks again, mate.

  0