Countries API | SSG -> NextJS | Styling -> Tailwind | State -> Zustand
Design comparison
Solution retrospective
I solved a problem with SSG and localstorage used by Zustand, where the local storage was not accessible during server rendering. But the app was left with a small flash when refreshing or going to the home page and using the dark theme. I would like to know how would you approach this please.
Also I highly appreciate any other kind of feedback, it is very very helpful to me, thank you.
Community feedback
- @ScottburgPosted almost 2 years ago
Well done Edgar, the asethetics on the site look good and close to spec. Nice job on the layout on different screen sizes and dark mode.
some points/opinions from me:
-
the population value would be better with commas seperating the thousands, millions etc.
-
Accessability - make sure that you are using the correct html tags for accessability. https://uxdesign.cc/semantic-html-the-foundation-of-web-accessibility-e5bbecad7c17
-
With the flash I'd guess that you are only applying the dark theme on the page after the page loads in light theme originally. Look into how you are applying the dark theme toggle on the app to make sure that it stays consistant on page changes.perhaps looking at where in the lifecycle its applied, or applying it to the dom itself.
Great job
0@Edgar-AvilaPosted almost 2 years ago@Scottburg, thank you very much, your feedback is a huge help. I will be looking onto the changes you suggested and try to implement them in the app.
0 -
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord