Coolest Sunnyside landing page with mobile and desktop view

Community feedback

• 

  Ejike•120

  @agkaysterPosted over 3 years ago

  Thanks Guys. But apart from the alignments, I thought we were told in the Challenge ReadMe that we could choose the fonts and colors we wanted? Except I missed something. Once again, thanks for the feedback.

  0
• 

  Hanif•570

  @1Hanif1Posted over 3 years ago

  Firstly, Amazing effort! nice work : ) Still needs quite some work on the alignments and placements of the elements, fonts, colors and stuff

  As for your questions,

  1. I am still a beginner in JavaScript and I do know how to make Hamburger menus but I don't understand some of the JavaScript that you have written. So apologies! I couldn't help :(

  2. For those underlines I would have inserted a div element with a class of, let's say, 'text-underline' inside the parent element containing the text 'Learn more'.

  You could also do that using pseudo elements in CSS, which is the better option in my opinion.

  With the parent div of 'Learn more' having 'width: fit-content' I would have applied the following CSS on 'text-underline'

  .text-underline{ width: 100%; height: 2px;
  background-color: yellow;
  transform: translateY(-2px);
  border-radius: 12px;
  }

  I just assumed those values of 12px and -2px. Actual value might be different

  Hopefully I was able to help. Still a beginner myself so I did what I could

  Anyways, once again Solid Effort brother 👍

  0
• 

  Julian Ifesiokwu•475

  @JulianIfesiokwuPosted over 3 years ago

  Hey bossman very good effort. You missed a few things though like the fonts to be used, the background color and the width of certain sections? For the width you can put both section in a div and use flexbox with a flex of 50% for each, worked for me. Other than the few i mentioned, solid effort.

  0