Cooding bootcamp slider solution with HTML, SASS and JS

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 4 years ago

  I don't think you've done a bad job, Amol! Using Grid is great, but I would actually not use minmax and auto-fill in this instance. For me, they're perfect for pages where you have lots of rows and columns of items, like the /challenges page on this site, for example. On something like this, I'd just use a media query to change the layout. You definitely can play around with the minmax and get it working for this solution, but it would be my preference not to use it for this kind of layout.

  I'd also recommend trying to go mobile-first and use min-width media queries instead of max-width. This often leads to less code, so it would get rid of some of the repetition.

  Don't be too hard on yourself though. You've done a good job! 👍

  0

  ---

  

  Amol Shrivastava•80

  @Amol-ShrivastavaPosted about 4 years ago

  @mattstuddert thanks matt, but I need to work to more on my CSS grid. What you suggest should be my criteria for deciding width for columns in a CSS grid, because this is the biggest confusion that I have, like how to decide the width of the column. So to solve this I use a minmax trick of defining columns minimum be 25rem and at max can grow to 1fr. Also, every video for the CSS grid appreciates auto-fit and auto-fill, so beginners like me think that it is the bypass for writing media queries to change the layout.

  0

  

  T

  Matt Studdert•13,611

  @mattstuddertPosted about 4 years ago

  @Amol-Shrivastava minmax mixed with auto-fill or auto-fit is great, but media queries are still a valid way to change the layout. Whether you use minmax or media queries will depend on the situation. But you'll get more and more comfortable with it the more you practice. So I wouldn't worry too much about the details at this point. I would keep practising and move onto the next project. You can always then come back to this one and refactor it, which would be a great exercise.

  0

  

  Amol Shrivastava•80

  @Amol-ShrivastavaPosted about 4 years ago

  @mattstuddert thanks matt for your guidance

  0