Design comparison
Solution retrospective
I have focused more on the overall responsiveness this time around, ensuring it looks good on 1920, 1440, tablets and smaller mobile screens, and I have managed to get the CSS and HTML part out of the way fairly quickly.
What challenges did you encounter, and how did you overcome them?Once again, given my inexperience with Javascript, I struggled quite a bit to get the code to work, and even in its current state, it's not exactly as it should be.
Still, I was able to get it all down myself which it's pretty nice. I clearly have to create many more projects to get used to and better at it haha
What specific areas of your project would you like help with?Any feedback helps, as always!
Community feedback
- @0xabdulkhaliqPosted 6 months ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have a suggestion regarding your code that I believe will be of great interest to you.
CSS 🎨:
- Looks like the component has not been centered properly. So let me explain, How you can easily center the component without using
margin
orpadding
.
- We don't need to use
margin
andpadding
to center the component both horizontally & vertically. Because usingmargin
orpadding
will not dynamical centers our component at all states
- You already using
Flexbox
for layout, but you didn't utilized it's full potential. Just addmin-height: 100vh;
to properly center the component.
- Now remove these styles, after removing you can able to see the changes
#main-container { margin-top: 5em; }
- Now your component has been properly centered
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful1@mihainrsPosted 6 months ago@0xabdulkhalid Thank you!
I always keep forgetting about that one. V. helpful since I kinda got lost in my own CSS code while trying to re-size everything for the different types of screens I was working with.
I appreciate it!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord