Design comparison
Community feedback
- @mofadaPosted 3 months ago
First of all, congratulations on completing the challenge.
Let me talk about my opinion on your code, of course, this is only my personal opinion.
First of all, from the page, compared with Solution and Design, your background color seems to be wrong, and some small details are not restored enough.
Secondly, in terms of HTML code, you directly use the
H2
tag. Normally, you should start with H1 instead of using H2 directly. Input and Label are used correctly, but radio group recommends usingfieldset
andlegend
to implement it.Then, in terms of input validation, you can use HTML's
required
to perform validation and reduce js code.<input type="text" id="firstName" name="firstName" class="input" required />
Using HTML's own validation can reduce your code0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord